ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc - Issue 678073003: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

Issue 678073003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h ('k') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

index 3085f6ab1f7675040f085293f55990c1ff28bc08..64433279ad50c3849b9ea918a7772e93a39d9e6a 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

@@ -108,7 +108,7 @@ class DesktopDragDropClientAuraX11::X11DragContext

X11DragContext(ui::X11AtomCache* atom_cache,

::Window local_window,

const XClientMessageEvent& event);

- virtual ~X11DragContext();

+ ~X11DragContext() override;

// When we receive an XdndPosition message, we need to have all the data

// copied from the other window before we process the XdndPosition

@@ -144,8 +144,8 @@ class DesktopDragDropClientAuraX11::X11DragContext

void MaskOperation(::Atom xdnd_operation, int* drag_operation) const;

// ui::PlatformEventDispatcher:

- virtual bool CanDispatchEvent(const ui::PlatformEvent& event) override;

- virtual uint32_t DispatchEvent(const ui::PlatformEvent& event) override;

+ bool CanDispatchEvent(const ui::PlatformEvent& event) override;

+ uint32_t DispatchEvent(const ui::PlatformEvent& event) override;

// The atom cache owned by our parent.

ui::X11AtomCache* atom_cache_;