Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 678073002: Parse Sky entities according to the spec (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -309 lines) Patch
M sky/engine/core/html/parser/HTMLEntityParser.h View 1 chunk +22 lines, -27 lines 0 comments Download
M sky/engine/core/html/parser/HTMLEntityParser.cpp View 1 chunk +89 lines, -223 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.h View 5 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/html/parser/HTMLTokenizer.cpp View 8 chunks +34 lines, -53 lines 0 comments Download
A sky/tests/parser/entity.html View 1 chunk +18 lines, -0 lines 0 comments Download
A sky/tests/parser/entity-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A + sky/tests/resources/dump-as-markup.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-10-27 20:03:21 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-10-27 20:04:11 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-10-27 20:05:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
768bdfd0c9cd8957b1e10538fd98fe1c92f15377 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698