Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 678043003: Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (Closed)

Created:
6 years, 1 month ago by hcm
Modified:
6 years, 1 month ago
Reviewers:
Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (patchset #3 id:40001 of https://codereview.chromium.org/685523002/) Reason for revert: Getting to revert for failures on image filter tests in Skia and Blink Original issue's description: > Rebaseline imagemagnifier and dropshadowimagefilter tests. > > BUG=skia: > TBR=hcm@google.com > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/0fc71ea432d3895ede198a24080f877e607cd264 TBR=senorblanco@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4984d473aba2c3ca2dc3ce834978718d4b9d56a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -478 lines) Patch
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus5-Adreno330-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Debug/expected-results.json View 2 chunks +37 lines, -37 lines 0 comments Download
M expectations/gm/Test-Android-Nexus9-TegraK1-Arm64-Release/expected-results.json View 2 chunks +37 lines, -37 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Daisy-MaliT604-Arm7-Release/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Debug/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-ChromeOS-Link-HD4000-x86_64-Release/expected-results.json View 3 chunks +8 lines, -10 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 5 chunks +14 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 5 chunks +14 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 5 chunks +14 lines, -17 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 7 chunks +16 lines, -19 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 8 chunks +28 lines, -24 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 8 chunks +28 lines, -24 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 8 chunks +28 lines, -24 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 8 chunks +28 lines, -24 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 10 chunks +10 lines, -10 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 6 chunks +6 lines, -6 lines 0 comments Download
M expectations/gm/ignored-tests.txt View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hcm
Created Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests.
6 years, 1 month ago (2014-10-28 03:52:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678043003/1
6 years, 1 month ago (2014-10-28 03:52:53 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 03:53:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 4984d473aba2c3ca2dc3ce834978718d4b9d56a8

Powered by Google App Engine
This is Rietveld 408576698