Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 678033002: Revert "Move AST node counting to post-pass" (Closed)

Created:
6 years, 1 month ago by wingo
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Move AST node counting to post-pass" This reverts commit 698356720824559a6bd81c24be707b44ac277526 for breaking regress-96526-002 among other things. TBR=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -106 lines) Patch
M src/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M src/ast-numbering.cc View 24 chunks +4 lines, -67 lines 0 comments Download
M src/compiler.h View 1 chunk +2 lines, -7 lines 0 comments Download
M src/compiler.cc View 6 chunks +12 lines, -24 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-pipeline.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
wingo
6 years, 1 month ago (2014-10-27 16:25:32 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24910 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698