Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: sky/engine/core/frame/ImageBitmapTest.cpp

Issue 678003003: Begin to remove heap/* (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/ElementData.cpp ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/frame/ImageBitmapTest.cpp
diff --git a/sky/engine/core/frame/ImageBitmapTest.cpp b/sky/engine/core/frame/ImageBitmapTest.cpp
index d9e08db8963d87c5edfc9b23abe7a9c954054616..5be8163221be848c9cdc1e51a183d959f331f60e 100644
--- a/sky/engine/core/frame/ImageBitmapTest.cpp
+++ b/sky/engine/core/frame/ImageBitmapTest.cpp
@@ -65,11 +65,6 @@ protected:
}
virtual void TearDown()
{
- // Garbage collection is required prior to switching out the
- // test's memory cache; image resources are released, evicting
- // them from the cache.
- Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
-
replaceMemoryCacheForTesting(m_globalMemoryCache.release());
}
@@ -153,9 +148,6 @@ TEST_F(ImageBitmapTest, ImageBitmapLiveResourcePriority)
// ImageBitmaps that do not contain any of the source image do not elevate CacheLiveResourcePriority.
ASSERT_EQ(memoryCache()->priority(imageOutsideCrop->cachedImage()), MemoryCacheLiveResourcePriorityLow);
}
- // Force a garbage collection to sweep out the local ImageBitmaps.
- Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
-
// CacheLiveResourcePriroity should return to CacheLiveResourcePriorityLow when no ImageBitmaps reference the image.
ASSERT_EQ(memoryCache()->priority(imageNoCrop->cachedImage()), MemoryCacheLiveResourcePriorityLow);
ASSERT_EQ(memoryCache()->priority(imageExteriorCrop->cachedImage()), MemoryCacheLiveResourcePriorityLow);
« no previous file with comments | « sky/engine/core/dom/ElementData.cpp ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698