Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 677983007: print preview: get rid of some superfluous voice feedback. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

print preview: get rid of some superfluous voice feedback. R=alekseys@chromium.org TBR=vitalybuka@chromium.org BUG=383955 Committed: https://crrev.com/82ca7f3076d0473e2e72e52c8b6625e6b0e55520 Cr-Commit-Position: refs/heads/master@{#302032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/print_preview/search/destination_list_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Dan Beam
6 years, 1 month ago (2014-10-28 04:38:56 UTC) #1
Aleksey Shlyapnikov
lgtm
6 years, 1 month ago (2014-10-30 03:27:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677983007/1
6 years, 1 month ago (2014-10-30 03:34:51 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-30 03:34:53 UTC) #6
Dan Beam
TBR=vitalybuka@ for OWNERS (he tends to defer to alekseys@ often anyways)
6 years, 1 month ago (2014-10-30 03:37:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677983007/1
6 years, 1 month ago (2014-10-30 03:37:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 04:18:56 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/82ca7f3076d0473e2e72e52c8b6625e6b0e55520 Cr-Commit-Position: refs/heads/master@{#302032}
6 years, 1 month ago (2014-10-30 04:19:39 UTC) #12
Vitaly Buka (NO REVIEWS)
6 years, 1 month ago (2014-10-30 19:02:14 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698