Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 677983006: Don't draw display when its OutputSurface is lost. (Closed)

Created:
6 years, 1 month ago by jbauman
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't draw display when its OutputSurface is lost. Drawing in this case isn't productive and can cause DCHECKs to be hit. Committed: https://crrev.com/61b0fa6e8f40444dac97349bdf99d4a8e4f986b6 Cr-Commit-Position: refs/heads/master@{#301571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/compositor/onscreen_display_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/onscreen_display_client.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years, 1 month ago (2014-10-28 00:05:35 UTC) #2
jamesr
lgtm
6 years, 1 month ago (2014-10-28 04:54:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677983006/1
6 years, 1 month ago (2014-10-28 05:09:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 06:01:22 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 06:02:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61b0fa6e8f40444dac97349bdf99d4a8e4f986b6
Cr-Commit-Position: refs/heads/master@{#301571}

Powered by Google App Engine
This is Rietveld 408576698