Allow duplicate property names in classes

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4021 matching lines @@
   static const ParserFlag always_flags[] = {
     kAllowClasses,
     kAllowHarmonyObjectLiterals
   };
   RunParserSyncTest(context_data, class_body_data, kSuccess, NULL, 0,
                     always_flags, arraysize(always_flags));
 }
 
 
 TEST(ClassMultipleConstructorErrors) {
   // We currently do not allow any duplicate properties in class bodies. This

[marja, 2014/10/28 08:30:22]

This comment seems out of date now.

   // test ensures that when we change that we still throw on duplicate
   // constructors.
   const char* context_data[][2] = {{"class C {", "}"},
                                    {"(class {", "});"},
                                    {NULL, NULL}};
 
   const char* class_body_data[] = {
     "constructor() {}; constructor() {}",
     NULL};
 
   static const ParserFlag always_flags[] = {
     kAllowClasses,
     kAllowHarmonyObjectLiterals
   };
   RunParserSyncTest(context_data, class_body_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
 }
 
 
-// TODO(arv): We should allow duplicate property names.
-// https://code.google.com/p/v8/issues/detail?id=3570
-DISABLED_TEST(ClassMultiplePropertyNamesNoErrors) {
+TEST(ClassMultiplePropertyNamesNoErrors) {
   const char* context_data[][2] = {{"class C {", "}"},
                                    {"(class {", "});"},
                                    {NULL, NULL}};
 
   const char* class_body_data[] = {
     "constructor() {}; static constructor() {}",
     "m() {}; static m() {}",
     "m() {}; m() {}",
+    "static m() {}; static m() {}",
+    "get m() {}; set m(_) {}; get m() {}; set m(_) {};",
     NULL};
 
   static const ParserFlag always_flags[] = {
     kAllowClasses,
     kAllowHarmonyObjectLiterals
   };
   RunParserSyncTest(context_data, class_body_data, kSuccess, NULL, 0,
                     always_flags, arraysize(always_flags));
 }
 
@@ skipping 166 matching lines @@
       "for(const x = 4, y of [1,2,3]) {}",
       "for(const x = 1, y = 2 in []) {}",
       "for(const x,y in []) {}",
       "for(const x = 1, y = 2 of []) {}",
       "for(const x,y of []) {}",
       NULL};
   static const ParserFlag always_flags[] = {kAllowHarmonyScoping};
   RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }