Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 677943002: Clarify that there is no :cue or :cue(...) pseudo-class (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Project:
blink
Visibility:
Public.

Description

Clarify that there is no :cue or :cue(...) pseudo-class The test passes with or without these changes, demonstrating that the ::cue pseudo-element is already the only one, as per the spec: http://dev.w3.org/html5/webvtt/#the-cue-pseudo-element TEST=LayoutTests/media/track/track-css-cue-pseudo-class.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184585

Patch Set 1 #

Patch Set 2 : test #

Total comments: 2

Patch Set 3 : banish <title> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A LayoutTests/media/track/track-css-cue-pseudo-class.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (2 generated)
philipj_slow
PTAL. In addition to not being per spec, I think that because of the "used ...
6 years, 1 month ago (2014-10-27 15:13:44 UTC) #2
philipj_slow
If I'm right then the title of this CL is bogus, it's rather removing dead ...
6 years, 1 month ago (2014-10-27 15:14:41 UTC) #3
rune
Please add tests which check that rules with :cue and :cue(...) are dropped. So, the ...
6 years, 1 month ago (2014-10-27 22:10:47 UTC) #4
philipj_slow
Would a test like this do? <!DOCTYPE html> <style> :cue { color: red; } :cue(i) ...
6 years, 1 month ago (2014-10-28 09:16:54 UTC) #5
rune
On 2014/10/28 09:16:54, philipj wrote: > Would a test like this do? > > <!DOCTYPE ...
6 years, 1 month ago (2014-10-28 10:03:36 UTC) #6
philipj_slow
test
6 years, 1 month ago (2014-10-29 10:22:52 UTC) #7
philipj_slow
See if that's OK :)
6 years, 1 month ago (2014-10-29 10:26:15 UTC) #8
rune
lgtm with nit. https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html File LayoutTests/media/track/track-css-cue-pseudo-class.html (right): https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html#newcode2 LayoutTests/media/track/track-css-cue-pseudo-class.html:2: <title>:cue pseudo-class is not supported and ...
6 years, 1 month ago (2014-10-29 10:32:46 UTC) #9
philipj_slow
https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html File LayoutTests/media/track/track-css-cue-pseudo-class.html (right): https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html#newcode2 LayoutTests/media/track/track-css-cue-pseudo-class.html:2: <title>:cue pseudo-class is not supported and dropped during parsing</title> ...
6 years, 1 month ago (2014-10-29 10:36:07 UTC) #10
rune
On 2014/10/29 at 10:36:07, philipj wrote: > https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html > File LayoutTests/media/track/track-css-cue-pseudo-class.html (right): > > https://codereview.chromium.org/677943002/diff/20001/LayoutTests/media/track/track-css-cue-pseudo-class.html#newcode2 ...
6 years, 1 month ago (2014-10-29 10:50:20 UTC) #11
philipj_slow
On 2014/10/29 10:50:20, rune wrote: > On 2014/10/29 at 10:36:07, philipj wrote: > > > ...
6 years, 1 month ago (2014-10-29 11:56:37 UTC) #12
philipj_slow
banish <title>
6 years, 1 month ago (2014-10-29 11:57:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677943002/40001
6 years, 1 month ago (2014-10-29 11:58:40 UTC) #15
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 13:03:21 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184585

Powered by Google App Engine
This is Rietveld 408576698