Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 677853002: Set keys for the device permissions dialog action buttons. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set keys for the device permissions dialog action buttons. This change makes the Select button active by default. The Return key will activate the Select button and the Esc key will activate the Cancel button. This makes the dialog fully operable from the keyboard. BUG=426737 Committed: https://crrev.com/7cf829d6733f446b1a7fbaf6f6063b59dd180792 Cr-Commit-Position: refs/heads/master@{#301302}

Patch Set 1 #

Patch Set 2 : Resaved XIB with Xcode 4.6.3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M chrome/app/nibs/DevicePermissionsPrompt.xib View 1 8 chunks +30 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Reilly Grant (use Gerrit)
6 years, 1 month ago (2014-10-25 13:17:58 UTC) #2
Avi (use Gerrit)
lgtm I have to trust you on this; the diff is useless. Looks like you ...
6 years, 1 month ago (2014-10-25 15:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677853002/1
6 years, 1 month ago (2014-10-25 17:00:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20086)
6 years, 1 month ago (2014-10-25 17:04:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677853002/20001
6 years, 1 month ago (2014-10-26 04:57:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-26 05:40:07 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-26 05:41:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cf829d6733f446b1a7fbaf6f6063b59dd180792
Cr-Commit-Position: refs/heads/master@{#301302}

Powered by Google App Engine
This is Rietveld 408576698