Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 677843005: Do not compile with Turbofan if we cannot deopt for debugging. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Do not compile with Turbofan if we cannot deopt for debugging. R=jarin@chromium.org BUG=v8:3660 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25020

Patch Set 1 #

Patch Set 2 : add assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/compiler.cc View 1 3 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 1 month ago (2014-10-30 07:47:13 UTC) #1
Yang
On 2014/10/30 07:47:13, Yang wrote: Added assertion to make sure we can deopt to unoptimized ...
6 years, 1 month ago (2014-10-30 08:10:10 UTC) #2
Jarin
lgtm. Thanks for looking into this!
6 years, 1 month ago (2014-10-30 09:15:26 UTC) #3
Yang
6 years, 1 month ago (2014-10-30 14:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25020 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698