Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 677843002: Updates the hotword settings page according to newest mocks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * hasError: (boolean|undefined), 9 * hasError: (boolean|undefined),
10 * hasUnrecoverableError: (boolean|undefined), 10 * hasUnrecoverableError: (boolean|undefined),
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
1137 if (opt_enabled && opt_error) 1137 if (opt_enabled && opt_error)
1138 $('hotword-search-setting-indicator').updateBasedOnError(); 1138 $('hotword-search-setting-indicator').updateBasedOnError();
1139 }, 1139 },
1140 1140
1141 /** 1141 /**
1142 * Activates the Audio History and Always-On Hotword sections from the 1142 * Activates the Audio History and Always-On Hotword sections from the
1143 * System settings page. 1143 * System settings page.
1144 * @private 1144 * @private
1145 */ 1145 */
1146 showHotwordAlwaysOnSection_: function() { 1146 showHotwordAlwaysOnSection_: function() {
1147 $('voice-section-title').hidden = false;
1148 $('hotword-always-on-search').hidden = false; 1147 $('hotword-always-on-search').hidden = false;
1149 $('audio-logging').hidden = false; 1148 $('audio-logging').hidden = false;
1150 }, 1149 },
1151 1150
1152 /** 1151 /**
1152 * Activates the Hotword section on devices with no DSP
1153 * from the System settings page.
1154 * @private
1155 */
1156 showHotwordNoDSPSection_: function() {
1157 $('hotword-no-dsp-search').hidden = false;
1158 },
1159
1160 /**
1153 * Event listener for the 'homepage is NTP' preference. Updates the label 1161 * Event listener for the 'homepage is NTP' preference. Updates the label
1154 * next to the 'Change' button. 1162 * next to the 'Change' button.
1155 * @param {Event} event The preference change event. 1163 * @param {Event} event The preference change event.
1156 */ 1164 */
1157 onHomePageIsNtpChanged_: function(event) { 1165 onHomePageIsNtpChanged_: function(event) {
1158 if (!event.value.uncommitted) { 1166 if (!event.value.uncommitted) {
1159 $('home-page-url').hidden = event.value.value; 1167 $('home-page-url').hidden = event.value.value;
1160 $('home-page-ntp').hidden = !event.value.value; 1168 $('home-page-ntp').hidden = !event.value.value;
1161 } 1169 }
1162 }, 1170 },
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
2039 'setSpokenFeedbackCheckboxState', 2047 'setSpokenFeedbackCheckboxState',
2040 'setThemesResetButtonEnabled', 2048 'setThemesResetButtonEnabled',
2041 'setVirtualKeyboardCheckboxState', 2049 'setVirtualKeyboardCheckboxState',
2042 'setupPageZoomSelector', 2050 'setupPageZoomSelector',
2043 'setupProxySettingsButton', 2051 'setupProxySettingsButton',
2044 'showBluetoothSettings', 2052 'showBluetoothSettings',
2045 'showCreateProfileError', 2053 'showCreateProfileError',
2046 'showCreateProfileSuccess', 2054 'showCreateProfileSuccess',
2047 'showCreateProfileWarning', 2055 'showCreateProfileWarning',
2048 'showHotwordAlwaysOnSection', 2056 'showHotwordAlwaysOnSection',
2057 'showHotwordNoDSPSection',
2049 'showHotwordSection', 2058 'showHotwordSection',
2050 'showMouseControls', 2059 'showMouseControls',
2051 'showSupervisedUserImportError', 2060 'showSupervisedUserImportError',
2052 'showSupervisedUserImportSuccess', 2061 'showSupervisedUserImportSuccess',
2053 'showTouchpadControls', 2062 'showTouchpadControls',
2054 'toggleExtensionIndicators', 2063 'toggleExtensionIndicators',
2055 'updateAccountPicture', 2064 'updateAccountPicture',
2056 'updateAutoLaunchState', 2065 'updateAutoLaunchState',
2057 'updateDefaultBrowserState', 2066 'updateDefaultBrowserState',
2058 'updateEasyUnlock', 2067 'updateEasyUnlock',
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
2107 } 2116 }
2108 button.textContent = loadTimeData.getString(strId); 2117 button.textContent = loadTimeData.getString(strId);
2109 }; 2118 };
2110 } 2119 }
2111 2120
2112 // Export 2121 // Export
2113 return { 2122 return {
2114 BrowserOptions: BrowserOptions 2123 BrowserOptions: BrowserOptions
2115 }; 2124 };
2116 }); 2125 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698