Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 677843002: Updates the hotword settings page according to newest mocks. (Closed)

Created:
6 years, 2 months ago by kcarattini
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updates the hotword settings page according to newest mocks. See bug for screenshots. BUG=390086 Committed: https://crrev.com/b022fc3af337186a85556e75fe78fb0afded68f5 Cr-Commit-Position: refs/heads/master@{#301743}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Review Comments #

Patch Set 4 : Review Comments #

Total comments: 8

Patch Set 5 : Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -35 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/browser_options.css View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 1 chunk +42 lines, -20 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
kcarattini
jhawkins: please review for OWNERS approval in all directories.
6 years, 1 month ago (2014-10-27 23:59:18 UTC) #2
rpetterson
lgtm
6 years, 1 month ago (2014-10-28 00:12:38 UTC) #3
James Hawkins
https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.css File chrome/browser/resources/options/browser_options.css (right): https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.css#newcode195 chrome/browser/resources/options/browser_options.css:195: padding-left: 8px; -webkit-padding-start (RTL) https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.html#newcode164 ...
6 years, 1 month ago (2014-10-28 22:42:55 UTC) #4
kcarattini
https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.css File chrome/browser/resources/options/browser_options.css (right): https://codereview.chromium.org/677843002/diff/1/chrome/browser/resources/options/browser_options.css#newcode195 chrome/browser/resources/options/browser_options.css:195: padding-left: 8px; On 2014/10/28 22:42:55, James Hawkins wrote: > ...
6 years, 1 month ago (2014-10-28 23:22:51 UTC) #5
James Hawkins
LGTM with nits. https://codereview.chromium.org/677843002/diff/60001/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/677843002/diff/60001/chrome/browser/resources/options/browser_options.html#newcode169 chrome/browser/resources/options/browser_options.html:169: i18n-values="href:hotwordLearnMoreURL"></a> nit: Closing tag should be ...
6 years, 1 month ago (2014-10-28 23:24:26 UTC) #6
kcarattini
https://codereview.chromium.org/677843002/diff/60001/chrome/browser/resources/options/browser_options.html File chrome/browser/resources/options/browser_options.html (right): https://codereview.chromium.org/677843002/diff/60001/chrome/browser/resources/options/browser_options.html#newcode169 chrome/browser/resources/options/browser_options.html:169: i18n-values="href:hotwordLearnMoreURL"></a> On 2014/10/28 23:24:26, James Hawkins wrote: > nit: ...
6 years, 1 month ago (2014-10-28 23:30:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677843002/80001
6 years, 1 month ago (2014-10-28 23:32:53 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-10-29 00:25:30 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 00:26:10 UTC) #11
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/b022fc3af337186a85556e75fe78fb0afded68f5
Cr-Commit-Position: refs/heads/master@{#301743}

Powered by Google App Engine
This is Rietveld 408576698