Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 677823002: Fix chrome://policy fall out from action-link change. (Closed)

Created:
6 years, 1 month ago by Dan Beam
Modified:
6 years, 1 month ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix chrome://policy fall out from action-link change. TBR=bartfab@chromium.org BUG=426850 Committed: https://crrev.com/db9275455bde7db0f0a63c029203f03cdf6a1d5b Cr-Commit-Position: refs/heads/master@{#301365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/policy.css View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Beam
general nit on the CSS in this file: https://github.com/CSSLint/csslint/wiki/Disallow-overqualified-elements (all the el.class are kind of ...
6 years, 1 month ago (2014-10-25 00:08:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677823002/1
6 years, 1 month ago (2014-10-25 00:10:10 UTC) #3
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-10-25 06:12:08 UTC) #5
bartfab (slow)
lgtm
6 years, 1 month ago (2014-10-27 14:33:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677823002/1
6 years, 1 month ago (2014-10-27 14:34:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 15:18:41 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 15:19:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db9275455bde7db0f0a63c029203f03cdf6a1d5b
Cr-Commit-Position: refs/heads/master@{#301365}

Powered by Google App Engine
This is Rietveld 408576698