[Arguments] Support getters and setters on non-strict arguments objects.

[Arguments] Support getters and setters on non-strict arguments objects.

R=ager@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=7433

[Mads Ager (chromium), 2011-03-30 10:38:37]

LGTM

http://codereview.chromium.org/6778008/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6778008/diff/1/src/objects.cc#newcode2610
src/objects.cc:2610: FixedArray::cast(this->elements())->set(1, dictionary);
Why the this-> here?

[Kevin Millikin (Chromium), 2011-03-30 10:55:27]

http://codereview.chromium.org/6778008/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6778008/diff/1/src/objects.cc#newcode2610
src/objects.cc:2610: FixedArray::cast(this->elements())->set(1, dictionary);
On 2011/03/30 10:38:37, Mads Ager wrote:
> Why the this-> here?

I shadowed the elements member function with an identically named local
variable.

[Mads Ager (chromium), 2011-03-30 11:01:18]

http://codereview.chromium.org/6778008/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/6778008/diff/1/src/objects.cc#newcode2610
src/objects.cc:2610: FixedArray::cast(this->elements())->set(1, dictionary);
On 2011/03/30 10:55:27, Kevin Millikin wrote:
> On 2011/03/30 10:38:37, Mads Ager wrote:
> > Why the this-> here?
> 
> I shadowed the elements member function with an identically named local
> variable.

That one should be called something else I think. That is not elements. It is
elements or the first element of the arguments elements backing store (which I
think had a name).