Adding color cube to fuzzer

Adding color cube to fuzzer

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/f11c57488205faddd10dffedcd3c122aac1935ad

[sugoi1, 2014-10-24 20:46:55]

sugoi@chromium.org changed reviewers:
+ bsalomon@google.com, senorblanco@google.com

[Stephen White, 2014-10-24 22:48:37]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2014-10-24 22:48:38]

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz.cpp
File samplecode/SampleFilterFuzz.cpp (right):

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz....
samplecode/SampleFilterFuzz.cpp:216: switch (R(5)) {
Nit: couldn't this also be

int size = 4 << R(5) ?

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz....
samplecode/SampleFilterFuzz.cpp:229: SkData* data =
SkData::NewUninitialized(sizeof(SkColor) * size * size * size);
Should we also be trying to give the fuzzer truncated buffers (ie., buffer <
size^3 in memory)? Or will the fuzzer hit that case automatically?

[Stephen White, 2014-10-24 22:49:00]

LGTM, btw. My comments above are nits.

[sugoi1, 2014-10-27 14:55:32]

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz.cpp
File samplecode/SampleFilterFuzz.cpp (right):

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz....
samplecode/SampleFilterFuzz.cpp:216: switch (R(5)) {
On 2014/10/24 22:48:37, Stephen White wrote:
> Nit: couldn't this also be
> 
> int size = 4 << R(5) ?

Done.

https://codereview.chromium.org/677713003/diff/1/samplecode/SampleFilterFuzz....
samplecode/SampleFilterFuzz.cpp:229: SkData* data =
SkData::NewUninitialized(sizeof(SkColor) * size * size * size);
On 2014/10/24 22:48:38, Stephen White wrote:
> Should we also be trying to give the fuzzer truncated buffers (ie., buffer <
> size^3 in memory)? Or will the fuzzer hit that case automatically?

Yeah, the fuzzer should take care of that case automatically.

[sugoi1, 2014-10-27 14:55:44]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-10-27 14:56:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/677713003/20001

[commit-bot: I haz the power, 2014-10-27 15:04:01]

Committed patchset #2 (id:20001) as f11c57488205faddd10dffedcd3c122aac1935ad