|
Revert of Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #1 id:1 of https://codereview.chromium.org/671183002/)
Reason for revert:
White success page and no way to proceed only reproduces for use_athena=1 builds.
This CL fixes that: https://codereview.chromium.org/642693003/
Re-landing.
Original issue's description:
> Revert of Inline sign in extracts gaia id from HTTP header and seeds account tracker (patchset #46 id:1740001 of https://codereview.chromium.org/473153002/)
>
> Reason for revert:
> This breaks Chrome OS GAIA login.
>
> After successful GAIA authentication uses sees blank white page and nothing happens.
>
> Please build chromeos=1 build and check that sign in as new user works fine before relanding this CL. Unfortunately autotests rely on fake gaia server and doesn't check this end-to-end sign in flow.
>
> Original issue's description:
> > Inline login handler extracts gaia id from HTTP header and seeds account tracker
> > service during sign in.
> >
> > BUG= 341408
> >
> > Committed: https://crrev.com/a8e7c94b1b79a0948d05a1fcfff53391d22ce37a
> > Cr-Commit-Position: refs/heads/master@{#300750}
>
> TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG= 341408
>
> Committed: https://crrev.com/bbaf207927765f4b7c7cae2a4af8db6c4c4a67ce
> Cr-Commit-Position: refs/heads/master@{#300873}
TBR=guohui@chromium.org,bartfab@chromium.org,xiyuan@chromium.org,achuith@chromium.org,davemoore@chromium.org,rogerta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 341408
Committed: https://crrev.com/07398a38454635dcbebac7898cbaa91969741e60
Cr-Commit-Position: refs/heads/master@{#301099}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+438 lines, -317 lines) |
Patch |
 |
M |
chrome/app/chromeos_strings.grdp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/saml/saml_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/session/user_session_manager.cc
|
View
|
|
3 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/signin/oauth2_login_manager.h
|
View
|
|
3 chunks |
+11 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
|
View
|
|
2 chunks |
+42 lines, -26 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/chromeos/login/signin/oauth2_login_manager_factory.cc
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/chromeos/login/login_common.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
|
View
|
|
4 chunks |
+7 lines, -30 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/chromeos/login/screen_gaia_signin.js
|
View
|
|
6 chunks |
+26 lines, -42 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/component_extension_resources.grd
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/gaia_auth/background.js
|
View
|
|
5 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/gaia_auth/main.js
|
View
|
|
13 chunks |
+50 lines, -47 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/gaia_auth/success.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/resources/gaia_auth/success.js
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/resources/gaia_auth_host/gaia_auth_host.js
|
View
|
|
7 chunks |
+49 lines, -46 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
|
View
|
|
3 chunks |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
|
View
|
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
|
View
|
|
6 chunks |
+21 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc
|
View
|
|
2 chunks |
+17 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
|
View
|
|
5 chunks |
+0 lines, -16 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/signin/inline_login_handler_impl.cc
|
View
|
|
12 chunks |
+37 lines, -31 lines |
0 comments
|
Download
|
 |
M |
chromeos/login/auth/user_context.h
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chromeos/login/auth/user_context.cc
|
View
|
|
4 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/signin/core/browser/account_tracker_service.h
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/signin/core/browser/account_tracker_service.cc
|
View
|
|
2 chunks |
+40 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/signin/core/browser/account_tracker_service_unittest.cc
|
View
|
|
3 chunks |
+22 lines, -0 lines |
0 comments
|
Download
|
 |
M |
google_apis/gaia/fake_gaia.h
|
View
|
|
3 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
M |
google_apis/gaia/fake_gaia.cc
|
View
|
|
6 chunks |
+41 lines, -4 lines |
0 comments
|
Download
|
 |
M |
tools/telemetry/telemetry/core/backends/chrome/chromeos_login_ext/main.js
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|