Issue 677683002: Fix bugs in Scheduler hoisting and RPO loop bounds computations.

Issue 677683002: Fix bugs in Scheduler hoisting and RPO loop bounds computations. (Closed)

Created:
6 years, 2 months ago by titzer

Modified:
6 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix bugs in Scheduler hoisting and RPO loop bounds computations. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24877

Patch Set 2 : Addressed comments. #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -86 lines)			Patch
	M	src/compiler/scheduler.cc	View	1	5 chunks	+38 lines, -29 lines	0 comments	Download
	M	test/cctest/compiler/test-scheduler.cc	View		20 chunks	+63 lines, -57 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/677683002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/677683002/diff/1/src/compiler/scheduler.cc#newcode564 src/compiler/scheduler.cc:564: // Compute the correct loop headersand ...

6 years, 2 months ago (2014-10-24 13:36:43 UTC) #2

titzer

https://codereview.chromium.org/677683002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/677683002/diff/1/src/compiler/scheduler.cc#newcode564 src/compiler/scheduler.cc:564: // Compute the correct loop headersand set the correct ...

6 years, 2 months ago (2014-10-24 13:41:46 UTC) #3

titzer

6 years, 2 months ago (2014-10-24 13:57:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 24877 (presubmit successful).

Expand Messages | Collapse Messages