Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 677633003: Improve printing for Symbols. (Closed)

Created:
6 years, 2 months ago by mvstanton
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Improve printing for Symbols. Private symbols we create in the heap don't have names, but we can resolve them to a constant string. This gives handy debugger output like: (gdb) job 0x2020c67d 0x2020c67d: [Symbol] - hash: 547385396 - name: 0x20208091 <undefined> (uninitialized_symbol) - private: 1 - own: 1 $7 = void (gdb) or with ShortPrint() in an array: ... [5]: 0x2020c67d <Symbol: 547385396 (uninitialized_symbol)> ... Printing help for internal symbols R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24869

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M src/objects.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +26 lines, -9 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Yang, Another bit of trivia, nicer printing for symbols. thx again, --Michael
6 years, 2 months ago (2014-10-24 11:28:05 UTC) #1
Yang
On 2014/10/24 11:28:05, mvstanton wrote: > Hi Yang, > Another bit of trivia, nicer printing ...
6 years, 2 months ago (2014-10-24 11:33:14 UTC) #2
mvstanton
6 years, 2 months ago (2014-10-24 12:36:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24869 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698