Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 67763007: Update benchmark test suite. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M test/benchmarks/testcfg.py View 1 5 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
7 years, 1 month ago (2013-11-19 17:57:39 UTC) #1
Jakob Kummerow
https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py File test/benchmarks/testcfg.py (right): https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py#newcode68 test/benchmarks/testcfg.py:68: "octane/gbemu-part2", Nope, this doesn't do what you want. Skip ...
7 years, 1 month ago (2013-11-20 09:35:15 UTC) #2
Yang
https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py File test/benchmarks/testcfg.py (right): https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py#newcode68 test/benchmarks/testcfg.py:68: "octane/gbemu-part2", On 2013/11/20 09:35:15, Jakob wrote: > Nope, this ...
7 years, 1 month ago (2013-11-20 11:04:08 UTC) #3
Jakob Kummerow
lgtm
7 years, 1 month ago (2013-11-20 12:42:36 UTC) #4
Yang
7 years, 1 month ago (2013-11-20 15:05:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17934 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698