Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 67763005: Add forced mode to push-to-trunk script. (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add forced mode to push-to-trunk script. This CL depends on https://codereview.chromium.org/65933003/. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17893

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed review comments. #

Total comments: 1

Patch Set 3 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M tools/push-to-trunk/common_includes.py View 1 2 7 chunks +26 lines, -5 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 1 2 5 chunks +24 lines, -9 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 2 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
7 years, 1 month ago (2013-11-19 12:19:32 UTC) #1
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py#newcode237 tools/push-to-trunk/common_includes.py:237: def DieInFocedMode(self, msg=""): s/Foced/Forced/ https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/push_to_trunk.py File ...
7 years, 1 month ago (2013-11-19 13:46:11 UTC) #2
Michael Achenbach
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py#newcode237 tools/push-to-trunk/common_includes.py:237: def DieInFocedMode(self, msg=""): On 2013/11/19 13:46:11, Jakob wrote: > ...
7 years, 1 month ago (2013-11-19 15:09:36 UTC) #3
Jakob Kummerow
Well, I'm not sure how much sense it makes to automate creation of the Chromium ...
7 years, 1 month ago (2013-11-19 16:25:33 UTC) #4
Michael Achenbach
7 years, 1 month ago (2013-11-20 08:49:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r17893.

Powered by Google App Engine
This is Rietveld 408576698