Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 6776012: [Arguments] Rename some identifiers. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

[Arguments] Rename some identifiers. Avoid using the identifier "elements" locally to describe the backing store containing the unaliased arguments object indexed properties. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7435

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -41 lines) Patch
M src/objects.cc View 9 chunks +40 lines, -41 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
9 years, 8 months ago (2011-03-30 12:01:26 UTC) #1
Kevin Millikin (Chromium)
http://codereview.chromium.org/6776012/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/6776012/diff/1/src/objects.cc#newcode2759 src/objects.cc:2759: if (backing_streo->map() == heap->non_strict_arguments_elements_map()) { I'll commit the version ...
9 years, 8 months ago (2011-03-30 12:02:45 UTC) #2
Mads Ager (chromium)
9 years, 8 months ago (2011-03-30 13:09:28 UTC) #3
LGTM, time to mess with the backing_streo!

Powered by Google App Engine
This is Rietveld 408576698