Issue 6776012: [Arguments] Rename some identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6776012: [Arguments] Rename some identifiers. (Closed)

Created:
9 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/arguments

Visibility:
Public.

Description

[Arguments] Rename some identifiers. Avoid using the identifier "elements" locally to describe the backing store containing the unaliased arguments object indexed properties. R=ager@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=7435

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -41 lines)			Patch
	M	src/objects.cc	View		9 chunks	+40 lines, -41 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/6776012/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/6776012/diff/1/src/objects.cc#newcode2759 src/objects.cc:2759: if (backing_streo->map() == heap->non_strict_arguments_elements_map()) { I'll commit the version ...

9 years, 8 months ago (2011-03-30 12:02:45 UTC) #2

LGTM, time to mess with the backing_streo!

Expand Messages | Collapse Messages