Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 677593002: [fsp] Fix flaky browser test for aborting a write operation. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Fix flaky browser test for aborting a write operation. Before, we were using a timer in hope that the operation is started synchronously, but it's a wrong assumption. This patch resolves this issue by waiting until writing is really started. TEST=browser_test: *FileSystemProvider*Write* BUG=426549 Committed: https://crrev.com/64b7e99ac3f6cb68d64c0de3e23fa018cde58fd7 Cr-Commit-Position: refs/heads/master@{#301051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/write_file/test.js View 2 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@fukino: PTAL. Thanks!
6 years, 2 months ago (2014-10-24 03:48:20 UTC) #2
fukino
On 2014/10/24 03:48:20, mtomasz wrote: > @fukino: PTAL. Thanks! lgtm. Thanks!
6 years, 2 months ago (2014-10-24 03:53:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677593002/1
6 years, 2 months ago (2014-10-24 03:54:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 04:55:50 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 04:57:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64b7e99ac3f6cb68d64c0de3e23fa018cde58fd7
Cr-Commit-Position: refs/heads/master@{#301051}

Powered by Google App Engine
This is Rietveld 408576698