chrome/browser/ui/views/bookmarks/bookmark_bar_view.h - Issue 677533003: Changes BookmarkBarView to only create buttons as needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 677533003: Changes BookmarkBarView to only create buttons as needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: done Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

index 1796f136838c4dbb608bfd6f36b322c986ffd5a8..0d5003976e1b3b0d8eca7f9af9299ba54e3312d9 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

@@ -321,6 +321,11 @@ class BookmarkBarView : public DetachableToolbarView,

// and icon.

void ConfigureButton(const BookmarkNode* node, views::LabelButton* button);

+ // Creates and adds a button for the next node of the bookmark bar node. The

+ // next node corresponds to the node at index GetBookmarkButtonCount(). This

+ // does not layout/paint. It's assumed the call site does that.

msw 2014/10/27 20:40:24 nit: I think you can remove "This does not layout/

sky 2014/10/27 21:48:18 I nuked this function entirely.

+ void LoadNextBookmarkButton();

// Implementation for BookmarkNodeAddedImpl. Returns true if LayoutAndPaint()

// is required.

bool BookmarkNodeAddedImpl(BookmarkModel* model,

« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('J')