Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h

Issue 677533003: Changes BookmarkBarView to only create buttons as needed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: really dont join Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
index 1796f136838c4dbb608bfd6f36b322c986ffd5a8..ea67de7d614cd0ae3379bce96f6314cdae956b07 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
@@ -286,9 +286,11 @@ class BookmarkBarView : public DetachableToolbarView,
// It's easy to get the mapping wrong. For this reason all these methods are
// private.
- // Returns the number of buttons corresponding to starred urls/folders. This
- // is equivalent to the number of children the bookmark bar node from the
- // bookmark bar model has.
+ // Returns the number of bookmark bar url/folder buttons that have been
+ // created. This does not necessarily represent the number of bookmark bar
+ // nodes, nor the number of visible bookmark bar buttons. Buttons are created
+ // lazily to fill available space, and may be hidden for ordering or sizing
+ // changes.
int GetBookmarkButtonCount() const;
// Returns the button at the specified index.
« no previous file with comments | « no previous file | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698