Issue 677533002: Update Cache.put() test to accept string as request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 677533002: Update Cache.put() test to accept string as request (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
asanka

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, jkarlin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Update Cache.put() test to accept string as request Per spec, the method signature is: Promise<Response> put((Request or USVString) request, Response response); So passing a string for request is perfectly valid. And thanks to the wonders of Web IDL + JavaScript, anything else passed in other than a Request will be coerced to a string, too. R=asanka@chromium.org BUG=374802 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184371

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review nit #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/cache-put-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

asanka@ - please take a look? Sorry I missed this during the original review. :(

6 years, 2 months ago (2014-10-23 21:03:27 UTC) #1

asanka

lgtm https://codereview.chromium.org/677533002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js File LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js (right): https://codereview.chromium.org/677533002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js#newcode163 LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js:163: 'Cache.put should accept a string as request'); Minor ...

6 years, 2 months ago (2014-10-24 04:59:07 UTC) #2

jsbell

6 years, 2 months ago (2014-10-24 16:43:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 184371 (presubmit successful).

Expand Messages | Collapse Messages