Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 677513003: Use gypi form of blink_skia_config. (Closed)

Created:
6 years, 2 months ago by bungeman-chromium
Modified:
6 years, 1 month ago
Reviewers:
jamesr, djsollen, tomhudson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use gypi form of blink_skia_config. The file blink_skia_config.gyp is changing to a gypi. This allows easier sharing between the gyp and gn build systems. Committed: https://crrev.com/c04fdebda718a7bb638500309f5dc96f67761215 Cr-Commit-Position: refs/heads/master@{#301105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M skia/BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download
M skia/skia_common.gypi View 2 chunks +7 lines, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bungeman-chromium
This will fix our gn build so that gn builds will also reflect changes to ...
6 years, 2 months ago (2014-10-23 22:41:53 UTC) #2
tomhudson
LGTM - however, the previous commit to set up the gypi also removed an extant ...
6 years, 2 months ago (2014-10-24 12:03:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677513003/1
6 years, 2 months ago (2014-10-24 14:52:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 15:47:13 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c04fdebda718a7bb638500309f5dc96f67761215 Cr-Commit-Position: refs/heads/master@{#301105}
6 years, 2 months ago (2014-10-24 15:48:05 UTC) #7
jamesr
This creates a logical cycle between modules - blink depends directly on both //third_party/skia and ...
6 years, 1 month ago (2014-10-27 06:00:08 UTC) #9
tomhudson
Thanks for pointing that out, James. Did we *introduce* a new circularity here, or was ...
6 years, 1 month ago (2014-10-27 15:39:18 UTC) #10
jamesr
6 years, 1 month ago (2014-10-28 23:48:09 UTC) #11
Message was sent while issue was closed.
I'm not sure.  Either way, this is a bad dependency.  Can you fix it?

Powered by Google App Engine
This is Rietveld 408576698