PrintPreview: While printing the preview data, set the initiator tab title as print job name.

chrome/browser/printing/print_view_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_view_manager.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/printing/print_job.h"
@@ skipping 42 matching lines @@
   scoped_refptr<PrintedDocument> document(print_job_->document());
   if (document) {
     // If IsComplete() returns false, the document isn't completely rendered.
     // Since our renderer is gone, there's nothing to do, cancel it. Otherwise,
     // the print job may finish without problem.
     TerminatePrintJob(!document->IsComplete());
   }
 }
 
 string16 PrintViewManager::RenderSourceName() {
-  string16 name(tab_contents()->GetTitle());
-  if (name.empty())
-    name = l10n_util::GetStringUTF16(IDS_DEFAULT_PRINT_DOCUMENT_TITLE);
-  return name;
+  if (job_title_.empty()) {

[stuartmorgan, 2011/03/30 22:59:17]

This is where some of that discussion should go. I'd still avoid talking about
how it got this way though, just that not being set means to use the tab title,
or default if it's empty.

+    string16 name(tab_contents()->GetTitle());
+    if (name.empty())
+      job_title_ = l10n_util::GetStringUTF16(IDS_DEFAULT_PRINT_DOCUMENT_TITLE);
+    else
+      job_title_ = name;
+  }
+  return job_title_;
 }
 
 GURL PrintViewManager::RenderSourceUrl() {
   NavigationEntry* entry = tab_contents()->controller().GetActiveEntry();
   if (entry)
     return entry->virtual_url();
   else
     return GURL();
 }
 
-void PrintViewManager::OnDidGetPrintedPagesCount(int cookie, int number_pages) {
+void PrintViewManager::OnDidGetBasicPrintJobInfo(
+    int cookie, int number_pages, const string16& job_title) {
   DCHECK_GT(cookie, 0);
   DCHECK_GT(number_pages, 0);
   number_pages_ = number_pages;
+  job_title_ = job_title;
+
   if (!OpportunisticallyCreatePrintJob(cookie))
     return;
 
   PrintedDocument* document = print_job_->document();
   if (!document || cookie != document->cookie()) {
     // Out of sync. It may happens since we are completely asynchronous. Old
     // spurious message can happen if one of the processes is overloaded.
     return;
   }
 }
@@ skipping 56 matching lines @@
                     params.page_size,
                     params.content_area,
                     params.has_visible_overlays);
 
   ShouldQuitFromInnerMessageLoop();
 }
 
 bool PrintViewManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PrintViewManager, message)
-    IPC_MESSAGE_HANDLER(PrintHostMsg_DidGetPrintedPagesCount,
-                        OnDidGetPrintedPagesCount)
+    IPC_MESSAGE_HANDLER(PrintHostMsg_DidGetBasicPrintJobInfo,
+                        OnDidGetBasicPrintJobInfo)
     IPC_MESSAGE_HANDLER(PrintHostMsg_DidPrintPage, OnDidPrintPage)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PrintViewManager::Observe(NotificationType type,
                                const NotificationSource& source,
                                const NotificationDetails& details) {
   switch (type.value) {
@@ skipping 259 matching lines @@
     return false;
   }
 
   // Settings are already loaded. Go ahead. This will set
   // print_job_->is_job_pending() to true.
   print_job_->StartPrinting();
   return true;
 }
 
 }  // namespace printing