Issue 677483005: [turbofan] Implement the correct semantics for integer division/modulus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 677483005: [turbofan] Implement the correct semantics for integer division/modulus. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

[turbofan] Implement the correct semantics for integer division/modulus. Also fix the sdiv/udiv instructions on ARM as a nice side effect. TEST=cctest,unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24888

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+391 lines, -62 lines)			Patch
M	src/arm/simulator-arm.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/base/bits.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/base/bits.cc	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/compiler/machine-operator-reducer.cc	View	1 2	5 chunks	+66 lines, -44 lines	0 comments	Download
M	test/cctest/test-assembler-arm.cc	View		3 chunks	+65 lines, -9 lines	0 comments	Download
M	test/unittests/base/bits-unittest.cc	View		1 chunk	+52 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View	1 2	2 chunks	+157 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years, 1 month ago (2014-10-26 12:50:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 24888 (presubmit successful).