Add GN rules for forwarder2 and chromium_commands

Add GN rules for forwarder2 and chromium_commands

These targets produce helpers used for running tests on android.

R=cjhopman@chromium.org

[jamesr, 2014-10-24 00:21:44]

https://codereview.chromium.org/677483004/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/commands/BUILD.gn (right):

https://codereview.chromium.org/677483004/diff/20001/build/android/pylib/devi...
build/android/pylib/device/commands/BUILD.gn:9:
android_library("chromium_commands") {
i want to end up with $OUT/lib.java/chromium_commands.dex.jar, but haven't
figured out the write template to produce that. any idea?

https://codereview.chromium.org/677483004/diff/20001/tools/android/forwarder2...
File tools/android/forwarder2/BUILD.gn (right):

https://codereview.chromium.org/677483004/diff/20001/tools/android/forwarder2...
tools/android/forwarder2/BUILD.gn:14: #      'variables': {
i think this is basically create_native_executable_dist(), but am not sure
exactly what the magic is or how to test it.

[cjhopman, 2014-10-24 01:23:35]

https://codereview.chromium.org/677483004/diff/20001/build/android/pylib/devi...
File build/android/pylib/device/commands/BUILD.gn (right):

https://codereview.chromium.org/677483004/diff/20001/build/android/pylib/devi...
build/android/pylib/device/commands/BUILD.gn:9:
android_library("chromium_commands") {
On 2014/10/24 00:21:44, jamesr wrote:
> i want to end up with $OUT/lib.java/chromium_commands.dex.jar, but haven't
> figured out the write template to produce that. any idea?

Ah, we moved almost all the intermediate files into the gen_dir (instead of the
root_dir) in GN. I think that, if we need to be able to treat the dex.jar as a
top-level output that other things refer to (we currently need that only for
chromium_commands), we should just allow you to provide "dex_path" to the
android_library template. I'd rather do that then allow people to assume things
about where otherwise intermediate files are created. See the comment in
rules.gni.

https://codereview.chromium.org/677483004/diff/20001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/677483004/diff/20001/build/config/android/rul...
build/config/android/rules.gni:686: _dex_path = _base_path + ".dex.jar"
We should be able to support a custom dex path by just setting this to
invoker.dex_path if it is provided.

https://codereview.chromium.org/677483004/diff/20001/tools/android/forwarder2...
File tools/android/forwarder2/BUILD.gn (right):

https://codereview.chromium.org/677483004/diff/20001/tools/android/forwarder2...
tools/android/forwarder2/BUILD.gn:14: #      'variables': {
On 2014/10/24 00:21:44, jamesr wrote:
> i think this is basically create_native_executable_dist(), but am not sure
> exactly what the magic is or how to test it.

Yeah, that's correct.

The magic should (mostly) just work. In a non-component build, the _dist
directory should contain just the forwarder executable. In a component build (if
that actually builds), the directory should contain the executable and any
shared libraries that it depends on.

[jamesr, 2014-10-24 05:36:32]

jamesr@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jamesr, 2014-10-24 05:36:33]

Thanks, PTAL.

jbudorick - PTAL for owners on build/android/pylib/device.  Why is there such
heavy use of 'set noparent' here?

[jbudorick, 2014-10-24 14:00:08]

b/a/pylib/device lgtm

We use noparent because build/OWNERS is *, which we didn't want in here.
Presumably, b/a/buildbot was set as noparent for a similar reason, although the
code in there is being phased out in favor of recipes anyway.

[qsr, 2014-10-31 08:55:40]

qsr@chromium.org changed reviewers:
+ qsr@chromium.org

[qsr, 2014-10-31 08:55:40]

James, I have a CL that does mostly the same thing here:
https://chromiumcodereview.appspot.com/684133002/

You can choose to continue this one, or get with mine, but you are missing a few
thing here:

1) Android binary must be compiled with -fPIE -pie. What we are building right
now doesn't run on device at all.
2) The host_forwarder will be in ${root_dir}/clang_x64/ where script do not
expect it. So you will probably want to copy it
3) All the tooling code is in fact chromium code and should be fixed instead of
using not chromium code.