Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: content/browser/renderer_host/p2p/socket_host.h

Issue 677473002: Implement UMA and internal data structure for tracking EWOULDBLOCK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/p2p/socket_host.h
diff --git a/content/browser/renderer_host/p2p/socket_host.h b/content/browser/renderer_host/p2p/socket_host.h
index 8a12898b35b5efeb8ca63284ec9b3fc0da2349b9..390c115efb6aa1702d4d676d0cf1b90404cb571b 100644
--- a/content/browser/renderer_host/p2p/socket_host.h
+++ b/content/browser/renderer_host/p2p/socket_host.h
@@ -91,6 +91,9 @@ class CONTENT_EXPORT P2PSocketHost {
protected:
friend class P2PSocketHostTcpTestBase;
+ // This should match suffix IPProtocolType defined in histograms.xml.
+ enum ProtocolType { UDP = 0x1, TCP = 0x2 };
+
// TODO(mallinath) - Remove this below enum and use one defined in
// libjingle/souce/talk/p2p/base/stun.h
enum StunMessageType {
@@ -125,7 +128,9 @@ class CONTENT_EXPORT P2PSocketHost {
STATE_ERROR,
};
- P2PSocketHost(IPC::Sender* message_sender, int socket_id);
+ P2PSocketHost(IPC::Sender* message_sender,
+ int socket_id,
+ ProtocolType protocol_type);
// Verifies that the packet |data| has a valid STUN header. In case
// of success stores type of the message in |type|.
@@ -142,6 +147,12 @@ class CONTENT_EXPORT P2PSocketHost {
size_t packet_length,
bool incoming);
+ // Used by subclasses to track the metrics of delayed bytes and packets.
+ void IncrementDelayedPackets();
+ void IncrementTotalSentPackets();
+ void IncrementDelayedBytes(uint32 size);
+ void DecrementDelayedBytes(uint32 size);
+
IPC::Sender* message_sender_;
int id_;
State state_;
@@ -151,6 +162,19 @@ class CONTENT_EXPORT P2PSocketHost {
base::WeakPtrFactory<P2PSocketHost> weak_ptr_factory_;
+ ProtocolType protocol_type_;
+
+ private:
+ // Track total delayed packets for calculating how many packets are
+ // delayed by system at the end of call.
+ uint32 send_packets_delayed_total_;
+ uint32 send_packets_total_;
+
+ // Track the maximum of consecutive delayed bytes caused by system's
+ // EWOULDBLOCK.
+ int32 send_bytes_delayed_max_;
+ int32 send_bytes_delayed_cur_;
+
DISALLOW_COPY_AND_ASSIGN(P2PSocketHost);
};
« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698