Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: content/browser/renderer_host/p2p/socket_host.cc

Issue 677473002: Implement UMA and internal data structure for tracking EWOULDBLOCK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_host.cc
diff --git a/content/browser/renderer_host/p2p/socket_host.cc b/content/browser/renderer_host/p2p/socket_host.cc
index 1693918bd32854572a8b085efa8b434cb61a3238..34dbbdf67a8104fe0c7c0b3a9ca3b17f80a2e2e1 100644
--- a/content/browser/renderer_host/p2p/socket_host.cc
+++ b/content/browser/renderer_host/p2p/socket_host.cc
@@ -4,6 +4,7 @@
#include "content/browser/renderer_host/p2p/socket_host.h"
+#include "base/metrics/histogram.h"
#include "base/sys_byteorder.h"
#include "content/browser/renderer_host/p2p/socket_host_tcp.h"
#include "content/browser/renderer_host/p2p/socket_host_tcp_server.h"
@@ -460,10 +461,21 @@ P2PSocketHost::P2PSocketHost(IPC::Sender* message_sender, int socket_id)
state_(STATE_UNINITIALIZED),
dump_incoming_rtp_packet_(false),
dump_outgoing_rtp_packet_(false),
- weak_ptr_factory_(this) {
+ weak_ptr_factory_(this),
+ send_queue_length_max_(0),
+ protocol_type_(P2PSocketHost::UNKNOWN) {
}
-P2PSocketHost::~P2PSocketHost() { }
+P2PSocketHost::~P2PSocketHost() {
+ DCHECK(protocol_type_ != P2PSocketHost::UNKNOWN);
+ if (protocol_type_ == P2PSocketHost::UDP) {
+ UMA_HISTOGRAM_COUNTS_100("WebRTC.MaxSystemConsecutiveEWB_UDP",
+ send_queue_length_max_);
+ } else {
+ UMA_HISTOGRAM_COUNTS_100("WebRTC.MaxSystemConsecutiveEWB_TCP",
+ send_queue_length_max_);
+ }
+}
// Verifies that the packet |data| has a valid STUN header.
// static

Powered by Google App Engine
This is Rietveld 408576698