Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 677453002: Remove android specific genID from SkPaint. (Closed)

Created:
6 years, 2 months ago by djsollen
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove android specific genID from SkPaint. Committed: https://skia.googlesource.com/skia/+/e3aee8fb7b041b3949fc912ef21b2e44650b7ee9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -98 lines) Patch
M include/core/SkPaint.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/core/SkPaint.cpp View 18 chunks +0 lines, -62 lines 0 comments Download
M tests/PaintTest.cpp View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
djsollen
6 years, 2 months ago (2014-10-23 16:22:53 UTC) #2
mtklein
On 2014/10/23 16:22:53, djsollen wrote: LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM LGTM
6 years, 2 months ago (2014-10-23 16:34:58 UTC) #3
reed1
LLLLLLLLLLL GGGGGGGGGG TTTTTTTTTTT MMMMMMMM (lgtm)
6 years, 2 months ago (2014-10-23 17:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677453002/1
6 years, 2 months ago (2014-10-23 17:13:52 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 17:23:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as e3aee8fb7b041b3949fc912ef21b2e44650b7ee9

Powered by Google App Engine
This is Rietveld 408576698