Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 677433002: Add floor, ceil, round (truncate) instructions for ia32, x64 (if SSE4.1) and (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix integer overflow. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ia32/instruction-selector-ia32.cc
diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc
index ca4bf1ba16f33ffd6bc7bd99fb3c32252b6b949a..ec818f2d415b9f27e696068f0e1d4bcb157e0105 100644
--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -596,6 +596,32 @@ void InstructionSelector::VisitFloat64Sqrt(Node* node) {
}
+void InstructionSelector::VisitFloat64Floor(Node* node) {
dcarney 2014/10/27 08:15:08 should dcheck that sse4.1 is supported here instea
sigurds 2014/10/28 12:47:22 Done.
+ IA32OperandGenerator g(this);
+ Emit(kSSEFloat64Floor, g.DefineAsRegister(node),
+ g.UseRegister(node->InputAt(0)));
+}
+
+
+void InstructionSelector::VisitFloat64Ceil(Node* node) {
+ IA32OperandGenerator g(this);
+ Emit(kSSEFloat64Ceil, g.DefineAsRegister(node),
+ g.UseRegister(node->InputAt(0)));
+}
+
+
+void InstructionSelector::VisitFloat64RoundTruncate(Node* node) {
+ IA32OperandGenerator g(this);
+ Emit(kSSEFloat64RoundTruncate, g.DefineAsRegister(node),
+ g.UseRegister(node->InputAt(0)));
+}
+
+
+void InstructionSelector::VisitFloat64RoundTiesAway(Node* node) {
+ UnsupportedOperator(node);
+}
+
+
void InstructionSelector::VisitCall(Node* node) {
IA32OperandGenerator g(this);
CallDescriptor* descriptor = OpParameter<CallDescriptor*>(node);
@@ -881,6 +907,11 @@ void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
// static
MachineOperatorBuilder::Flags
InstructionSelector::SupportedMachineOperatorFlags() {
+ if (CpuFeatures::IsSupported(SSE4_1)) {
+ return MachineOperatorBuilder::Flag::kFloat64Floor |
+ MachineOperatorBuilder::Flag::kFloat64Ceil |
+ MachineOperatorBuilder::Flag::kFloat64RoundTruncate;
+ }
return MachineOperatorBuilder::Flag::kNoFlags;
}
} // namespace compiler

Powered by Google App Engine
This is Rietveld 408576698