Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 67743002: Add tooltips for font scale factor and device pixel ratio (Closed)

Created:
7 years, 1 month ago by pdr.
Modified:
7 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Add tooltips for font scale factor and device pixel ratio This patch adds some minor UI tooltips for font scale factor and device pixel ratio in the inspector's emulation view. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161692

Patch Set 1 #

Patch Set 2 : Rietveld... #

Total comments: 1

Patch Set 3 : Tweak wording #

Patch Set 4 : More grammar tweaks. English iz hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/OverridesView.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pdr.
7 years, 1 month ago (2013-11-09 05:28:14 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/67743002/diff/30001/Source/devtools/front_end/OverridesView.js File Source/devtools/front_end/OverridesView.js (right): https://codereview.chromium.org/67743002/diff/30001/Source/devtools/front_end/OverridesView.js#newcode569 Source/devtools/front_end/OverridesView.js:569: this._deviceScaleFactorOverrideElement.title = WebInspector.UIString("Ratio between a device's physical pixels ...
7 years, 1 month ago (2013-11-09 14:15:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/67743002/110001
7 years, 1 month ago (2013-11-09 22:55:31 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-10 00:07:42 UTC) #4
Message was sent while issue was closed.
Change committed as 161692

Powered by Google App Engine
This is Rietveld 408576698