Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 677423004: Add unittest coverage for WriteToClipboard with a single URL (Closed)

Created:
6 years, 1 month ago by hichris123
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add unittest coverage for WriteToClipboard with a single URL Added unittest coverage removed from CL 634523004 BUG=57376 Committed: https://crrev.com/36a8fb2d8a945965352fdd856a43f40a193774c6 Cr-Commit-Position: refs/heads/master@{#301538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M components/bookmarks/browser/bookmark_node_data_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hichris123
Added unittest you requested be added to another CL.
6 years, 1 month ago (2014-10-27 22:26:36 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-10-27 23:50:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677423004/1
6 years, 1 month ago (2014-10-27 23:57:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 01:18:05 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 01:18:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36a8fb2d8a945965352fdd856a43f40a193774c6
Cr-Commit-Position: refs/heads/master@{#301538}

Powered by Google App Engine
This is Rietveld 408576698