Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 677423003: Null check content view core before using it. (Closed)

Created:
6 years, 1 month ago by hush (inactive)
Modified:
6 years, 1 month ago
Reviewers:
no sievers, boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, sgurun-gerrit only, boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Null check content view core before using it. This is because content view core object could be destroyed at the time when a method is called on it. BUG=427684 Committed: https://crrev.com/854fc333d0a4b258ab3a64eaa4111fa45855ce9d Cr-Commit-Position: refs/heads/master@{#301548}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hush (inactive)
PTAL
6 years, 1 month ago (2014-10-27 22:17:13 UTC) #2
hush (inactive)
On 2014/10/27 22:17:13, hush wrote: > PTAL internal bug b/18138575
6 years, 1 month ago (2014-10-27 22:17:34 UTC) #3
boliu
-> sievers for review for realz https://codereview.chromium.org/677423003/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/677423003/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1119 content/browser/renderer_host/render_widget_host_view_android.cc:1119: // Content view ...
6 years, 1 month ago (2014-10-27 22:19:06 UTC) #5
hush (inactive)
https://codereview.chromium.org/677423003/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/677423003/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode1119 content/browser/renderer_host/render_widget_host_view_android.cc:1119: // Content view core may possibly be destructed at ...
6 years, 1 month ago (2014-10-27 22:24:03 UTC) #6
no sievers
lgtm
6 years, 1 month ago (2014-10-27 23:46:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/677423003/20001
6 years, 1 month ago (2014-10-28 00:02:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-28 02:15:35 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 02:16:05 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/854fc333d0a4b258ab3a64eaa4111fa45855ce9d
Cr-Commit-Position: refs/heads/master@{#301548}

Powered by Google App Engine
This is Rietveld 408576698