Add a has_media flag to VolumeMetadata.

Add a has_media flag to VolumeMetadata.

The new flag carries the has_media status of a volume through from the DiskMountManager, so the information is available to chrome.fileManagerPrivate.onMountCompleted javascript listeners.

This is a re-land of issue 668013004, which fixes some initialization problems in VolumeInfo, which were causing flakey behaviour in tests.

BUG=420680
TEST=browser_tests: FileManagerPrivateApiTest.* FileManagerJsTest.*

Committed: https://crrev.com/da43a4428324e8869d06d6ef8aac849328402dd6
Cr-Commit-Position: refs/heads/master@{#302186}

[Ben Kwa, 2014-10-28 19:39:21]

kenobi@chromium.org changed reviewers:
+ mkearney@chromium.org, mtomasz@chromium.org

[Ben Kwa, 2014-10-28 20:30:18]

Re-landing issue 668013004.  This is basically the same change with a fix to the
VolumeInfo construction code to properly initialize the new struct member.

Thanks!

[mtomasz, 2014-10-29 00:50:42]

Please add TEST= line. lgtm with one nit.

https://codereview.chromium.org/677413007/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/volume_manager.cc (right):

https://codereview.chromium.org/677413007/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/volume_manager.cc:229: is_read_only(false)
{
Please add has_media_(false).

[kenobi, 2014-10-29 14:56:32]

kenobi@google.com changed reviewers:
+ kenobi@google.com

[kenobi, 2014-10-29 14:56:33]

https://codereview.chromium.org/677413007/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/volume_manager.cc (right):

https://codereview.chromium.org/677413007/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/volume_manager.cc:229: is_read_only(false)
{
On 2014/10/29 00:50:42, mtomasz wrote:
> Please add has_media_(false).

*facepalm* Amazing how quickly the c++-fu is evaporating from my brain.  Done.

[mkearney1, 2014-10-30 18:53:22]

lgtm

[Ben Kwa, 2014-10-30 22:15:03]

The CQ bit was checked by kenobi@chromium.org

[commit-bot: I haz the power, 2014-10-30 22:16:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/677413007/40001

[commit-bot: I haz the power, 2014-10-30 23:11:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-30 23:12:09]

Patchset 3 (id:??) landed as
https://crrev.com/da43a4428324e8869d06d6ef8aac849328402dd6
Cr-Commit-Position: refs/heads/master@{#302186}