Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 677403002: Revert 'Introduce phantom weak handles in the API and use them internally for debug info' (Closed)

Created:
6 years, 1 month ago by Erik Corry Chromium.org
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Revert 'Introduce phantom weak handles in the API and use them internally for debug info' Revert of https://codereview.chromium.org/649563006/ due to layout test failures. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24901

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -183 lines) Patch
M include/v8.h View 4 chunks +7 lines, -38 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug.cc View 9 chunks +21 lines, -24 lines 0 comments Download
M src/global-handles.h View 1 chunk +7 lines, -16 lines 0 comments Download
M src/global-handles.cc View 8 chunks +19 lines, -55 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +8 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Starzinger
LGTM (rubber-stamped).
6 years, 1 month ago (2014-10-27 12:02:11 UTC) #2
Erik Corry Chromium.org
6 years, 1 month ago (2014-10-27 12:03:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698