Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Unified Diff: functional/popups.py

Issue 6774001: Adding some logging for the test, testLaunchBlockedPopupInIncognito, to figure out its flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: functional/popups.py
===================================================================
--- functional/popups.py (revision 79706)
+++ functional/popups.py (working copy)
@@ -62,9 +62,12 @@
def testLaunchBlockedPopupInIncognito(self):
"""Verify that a blocked popup can be unblocked in incognito."""
self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
+ self.assertTrue(2, self.GetBrowserWindowCount())
file_url = self.GetFileURLForPath(os.path.join(
self.DataDir(), 'popup_blocker', 'popup-window-open.html'))
self.NavigateToURL(file_url, 1, 0)
+ self.assertEquals('Popup created using window.open',
+ self.GetActiveTabTitle(window_index=1))
# Wait until the popup is blocked
self.assertTrue(self.WaitUntil(lambda:
len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)) is 1),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698