pkg/analyzer/test/generated/resolver_test.dart - Issue 677303002: Remove unnecessary List creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/test/generated/resolver_test.dart

Issue 677303002: Remove unnecessary List creation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/resolver.dart ('K') | « pkg/analyzer/test/generated/all_the_rest.dart ('k') | pkg/analyzer/test/generated/utilities_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/test/generated/resolver_test.dart

diff --git a/pkg/analyzer/test/generated/resolver_test.dart b/pkg/analyzer/test/generated/resolver_test.dart

index a11bf523740798a06d89efd213d0a9761840cac7..7ef91644210d64e4395bd383130455d04632f6ba 100644

--- a/pkg/analyzer/test/generated/resolver_test.dart

+++ b/pkg/analyzer/test/generated/resolver_test.dart

@@ -4158,7 +4158,7 @@ class InheritanceManagerTest extends EngineTestCase {

MethodElementImpl methodMinB = ElementFactory.methodElement(methodName, _typeProvider.intType, []);

classB.methods = <MethodElement> [methodMinB];

List<ExecutableElement> overrides = _inheritanceManager.lookupOverrides(classB, methodName);

- EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA], new List.from(overrides));

+ EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA], overrides);

_assertNoErrors(classA);

_assertNoErrors(classB);

}

@@ -4173,7 +4173,7 @@ class InheritanceManagerTest extends EngineTestCase {

MethodElementImpl methodMinB = ElementFactory.methodElement(methodName, _typeProvider.intType, []);

classB.methods = <MethodElement> [methodMinB];

List<ExecutableElement> overrides = _inheritanceManager.lookupOverrides(classB, methodName);

- EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA], new List.from(overrides));

+ EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA], overrides);

_assertNoErrors(classA);

_assertNoErrors(classB);

}

@@ -4191,7 +4191,7 @@ class InheritanceManagerTest extends EngineTestCase {

MethodElementImpl methodMinC = ElementFactory.methodElement(methodName, _typeProvider.numType, []);

classC.methods = <MethodElement> [methodMinC];

List<ExecutableElement> overrides = _inheritanceManager.lookupOverrides(classC, methodName);

- EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA, methodMinB], new List.from(overrides));

+ EngineTestCase.assertEqualsIgnoreOrder(<Object> [methodMinA, methodMinB], overrides);

_assertNoErrors(classA);

_assertNoErrors(classB);

_assertNoErrors(classC);

@@ -8383,7 +8383,7 @@ class StaticTypeAnalyzerTest extends EngineTestCase {

}

FunctionExpression node = AstFactory.functionExpression2(parameters, body);

FunctionElementImpl element = new FunctionElementImpl.forNode(null);

- element.parameters = new List.from(parameterElements);

+ element.parameters = parameterElements;

element.type = new FunctionTypeImpl.con1(element);

node.element = element;

return node;