pkg/analyzer/lib/src/generated/constant.dart - Issue 677303002: Remove unnecessary List creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/constant.dart

Issue 677303002: Remove unnecessary List creation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/constant.dart

diff --git a/pkg/analyzer/lib/src/generated/constant.dart b/pkg/analyzer/lib/src/generated/constant.dart

index 23dec9e39e5d3102509ff25020007ff2c5fa544f..5f6978e1b8f30624b73ed41ae0a76445ee73e79c 100644

--- a/pkg/analyzer/lib/src/generated/constant.dart

+++ b/pkg/analyzer/lib/src/generated/constant.dart

@@ -1195,7 +1195,7 @@ class ConstantVisitor extends UnifyingAstVisitor<DartObjectImpl> {

}

InterfaceType listType = _typeProvider.listType.substitute4([elementType]);

- return new DartObjectImpl(listType, new ListState(new List.from(elements)));

+ return new DartObjectImpl(listType, new ListState(elements));

}

@override