Remove unnecessary List creation

pkg/analyzer/lib/src/generated/ast.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.ast;
 
 import 'dart:collection';
@@ skipping 179 matching lines @@
   }
 
   /**
    * Return an array containing the comment and annotations associated with this node, sorted in
    * lexical order.
    *
    * @return the comment and annotations associated with this node in the order in which they
    *         appeared in the original source
    */
   List<AstNode> get sortedCommentAndAnnotations {
-    List<AstNode> childList = new List<AstNode>();
-    childList.add(_comment);
-    childList.addAll(_metadata);
-    List<AstNode> children = new List.from(childList);
+    List<AstNode> children = new List<AstNode>();
+    children.add(_comment);
+    children.addAll(_metadata);
     children.sort(AstNode.LEXICAL_ORDER);
     return children;

[sra1, 2014/10/26 06:31:39]

or 

return <AstNode>[]
  ..add(_comment)
  ..addAll(_metadata)
  ..sort(AstNode.LEXICAL_ORDER);

[Brian Wilkerson, 2014/10/26 15:15:46]

Done. I am more concerned at the moment about performance issues than I am about
making the code more Dart-like, but since you mentioned it...

   }
 }
 
 /**
  * Instances of the class `Annotation` represent an annotation that can be associated with an
  * AST node.
  *
  * <pre>
  * metadata ::=
  *     annotation*
@@ skipping 4102 matching lines @@
   }
 
   /**
    * Return an array containing all of the directives and declarations in this compilation unit,
    * sorted in lexical order.
    *
    * @return the directives and declarations in this compilation unit in the order in which they
    *         appeared in the original source
    */
   List<AstNode> get sortedDirectivesAndDeclarations {
-    List<AstNode> childList = new List<AstNode>();
-    childList.addAll(_directives);
-    childList.addAll(_declarations);
-    List<AstNode> children = new List.from(childList);
+    List<AstNode> children = new List<AstNode>();
+    children.addAll(_directives);
+    children.addAll(_declarations);
     children.sort(AstNode.LEXICAL_ORDER);
     return children;
   }
 }
 
 /**
  * Instances of the class `CompilationUnitMember` defines the behavior common to nodes that
  * declare a name within the scope of a compilation unit.
  *
  * <pre>
@@ skipping 8882 matching lines @@
   }
 
   /**
    * Return an array containing the comment and annotations associated with this parameter, sorted
    * in lexical order.
    *
    * @return the comment and annotations associated with this parameter in the order in which they
    *         appeared in the original source
    */
   List<AstNode> get sortedCommentAndAnnotations {
-    List<AstNode> childList = new List<AstNode>();
-    childList.add(_comment);
-    childList.addAll(_metadata);
-    List<AstNode> children = new List.from(childList);
+    List<AstNode> children = new List<AstNode>();
+    children.add(_comment);
+    children.addAll(_metadata);
     children.sort(AstNode.LEXICAL_ORDER);
     return children;
   }
 }
 
 /**
  * Instances of the class `NullLiteral` represent a null literal expression.
  *
  * <pre>
  * nullLiteral ::=
@@ skipping 6460 matching lines @@
     _elements[index] = node;
   }
   void clear() {
     _elements = <E> [];
   }
   int get length => _elements.length;
   void set length(int value) {
     throw new UnsupportedError("Cannot resize NodeList.");
   }
 }