Fixing trybot failure

Fixing trybot failure

BUG=410400
Committed: https://crrev.com/1cb1b686744f945f12a589ad26c3620b5a82648a
Cr-Commit-Position: refs/heads/master@{#301277}

[Mr4D (OOO till 08-26), 2014-10-25 04:37:34]

skuhne@chromium.org changed reviewers:
+ oshima@chromium.org

[Mr4D (OOO till 08-26), 2014-10-25 04:37:43]

Please have a look!

[oshima, 2014-10-25 05:10:31]

lgtm with a nit

and do we know why it doesn't work with sandbox?
is this something we need to fix eventually?

https://codereview.chromium.org/677233002/diff/1/athena/test/chrome/athena_ap...
File athena/test/chrome/athena_app_browsertest.cc (right):

https://codereview.chromium.org/677233002/diff/1/athena/test/chrome/athena_ap...
athena/test/chrome/athena_app_browsertest.cc:16: const char kNoNaclSandbox[] =
"--no-sandbox";
can you use kNoSandbox in content/public/common/content_switches.cc?

[Mr4D (OOO till 08-26), 2014-10-25 05:26:01]

I did already check everywhere for a definition of that command earlier myself
and it is not explicitly defined anywhere.
We might add it later though.

In regards to this flag in general: 
- I have found countless exceptions of where we do specify the flag (py as well
as cc wise).
- In order to use the sandbox more is required for compiling - however unless we
really need the Nacl sandbox for something I do not see a reason why we should
build with it since it costs time and does not make a difference for our current
tests.

If you want me to add the constant as a content_switches.cc define I will do
that later. Let me know.

[Mr4D (OOO till 08-26), 2014-10-25 05:26:06]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-10-25 05:26:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/677233002/1

[commit-bot: I haz the power, 2014-10-25 06:14:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-25 06:14:57]

Patchset 1 (id:??) landed as
https://crrev.com/1cb1b686744f945f12a589ad26c3620b5a82648a
Cr-Commit-Position: refs/heads/master@{#301277}

[oshima, 2014-10-25 07:35:33]

On 2014/10/25 05:26:01, Mr4D wrote:
> I did already check everywhere for a definition of that command earlier myself
> and it is not explicitly defined anywhere.
> We might add it later though.
>
> In regards to this flag in general: 
> - I have found countless exceptions of where we do specify the flag (py as
well
> as cc wise).
> - In order to use the sandbox more is required for compiling - however unless
we
> really need the Nacl sandbox for something I do not see a reason why we should
> build with it since it costs time and does not make a difference for our
current
> tests.
> 
> If you want me to add the constant as a content_switches.cc define I will do
> that later. Let me know.

It already has one:

https://code.google.com/p/chromium/codesearch#chromium/src/content/public/com...

[Mr4D (OOO till 08-26), 2014-10-25 15:48:09]

Maybe it was too late - I looked for a "kNoNaclSandbox" (and also must have
mistyped the switch when searching. New CL is on the way.