Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 677223002: Remove some more frame-level scrolling machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/frame/Window.idl ('k') | sky/engine/public/web/WebFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index 2924c5795d6dd024b23b106f03bb0816c8842359..93c9ec88a7b4c83d5c3f3c34c7da05e0ef94b84e 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -668,13 +668,6 @@ void RenderBox::scrollByRecursively(const IntSize& delta, ScrollOffsetClamping c
if (frame && frame->page())
frame->page()->autoscrollController().updateAutoscrollRenderer();
}
- } else if (view()->frameView()) {
- // If we are here, we were called on a renderer that can be programmatically scrolled, but doesn't
- // have an overflow clip. Which means that it is a document node that can be scrolled.
- view()->frameView()->scrollBy(delta);
-
- // FIXME: If we didn't scroll the whole way, do we want to try looking at the frames ownerElement?
- // https://bugs.webkit.org/show_bug.cgi?id=28237
}
}
« no previous file with comments | « sky/engine/core/frame/Window.idl ('k') | sky/engine/public/web/WebFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698