chrome/browser/chromeos/file_manager/file_manager_jstest.cc - Issue 677213002: Add ImportHistory class and RecordStorage class.

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_jstest.cc

Issue 677213002: Add ImportHistory class and RecordStorage class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nuke an obsolete comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/test/data/file_manager/unit_tests/import_history_unittest.html » ('j') | chrome/test/data/file_manager/unit_tests/import_history_unittest.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <vector>	5 #include <vector>

6	6

7 #include "chrome/browser/ui/browser.h"	7 #include "chrome/browser/ui/browser.h"

8 #include "chrome/browser/ui/tabs/tab_strip_model.h"	8 #include "chrome/browser/ui/tabs/tab_strip_model.h"

9 #include "chrome/test/base/in_process_browser_test.h"	9 #include "chrome/test/base/in_process_browser_test.h"

10 #include "chrome/test/base/ui_test_utils.h"	10 #include "chrome/test/base/ui_test_utils.h"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53	53

54 IN_PROC_BROWSER_TEST_F(	54 IN_PROC_BROWSER_TEST_F(

55 FileManagerJsTest, MetadataCacheTest) {	55 FileManagerJsTest, MetadataCacheTest) {

56 RunTest(base::FilePath(FILE_PATH_LITERAL("metadata_cache_unittest.html")));	56 RunTest(base::FilePath(FILE_PATH_LITERAL("metadata_cache_unittest.html")));

57 }	57 }

58	58

59 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileOperationManagerTest) {	59 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileOperationManagerTest) {

60 RunTest(base::FilePath(	60 RunTest(base::FilePath(

61 FILE_PATH_LITERAL("file_operation_manager_unittest.html")));	61 FILE_PATH_LITERAL("file_operation_manager_unittest.html")));

62 }	62 }

	63

	64 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ImportHistoryTest) {
	mtomasz 2014/10/27 00:40:11 Please add TEST=browser_test: ImportHistoryTest Please add TEST=browser_test: ImportHistoryTest or sth like that to the CL description. Steve McKay 2014/10/27 21:06:28 Done. Q: What's the background on that? Does it s Show quoted text On 2014/10/27 00:40:11, mtomasz wrote: > Please add TEST=browser_test: ImportHistoryTest or sth like that to the CL > description. Done. Q: What's the background on that? Does it serve a functional role, or just informative? mtomasz 2014/10/28 01:36:32 Good question. I was asked by testers to write a w Show quoted text On 2014/10/27 21:06:28, Steve McKay wrote: > On 2014/10/27 00:40:11, mtomasz wrote: > > Please add TEST=browser_test: ImportHistoryTest or sth like that to the CL > > description. > > Done. > > Q: What's the background on that? Does it serve a functional role, or just > informative? Good question. I was asked by testers to write a way to verify each CL. If it's automatically tested, then they would like to know about it. But I'm not really sure if it's a hard rule. Steve McKay 2014/10/28 18:04:01 I don't mind. Just wondering. Show quoted text On 2014/10/28 01:36:32, mtomasz wrote: > On 2014/10/27 21:06:28, Steve McKay wrote: > > On 2014/10/27 00:40:11, mtomasz wrote: > > > Please add TEST=browser_test: ImportHistoryTest or sth like that to the CL > > > description. > > > > Done. > > > > Q: What's the background on that? Does it serve a functional role, or just > > informative? > > Good question. I was asked by testers to write a way to verify each CL. If it's > automatically tested, then they would like to know about it. But I'm not really > sure if it's a hard rule. I don't mind. Just wondering.
	65 RunTest(base::FilePath(

	66 FILE_PATH_LITERAL("import_history_unittest.html")));

	67 }

OLD	NEW