ozone: evdev: Handle mouse events

ozone: evdev: Handle mouse events

This CL renames KeyEventConverterEvdev to EventConverterEvdevImpl, adding mouse
support there. It adds converter for mouse events that handles move and button
events. This is useful for simple mouse testing and also systems that don't
want the complexity of gestures library.

I don't have a multipurpose input device just like described in
crbug.com/412996, but I believe this benefits the needed changes towards that
goal as well.

BUG=412996
TEST=Run chrome target on DRI platform on non-CrOS.

Committed: https://crrev.com/e6e890a7ead1cca18d7f9fa9c75d9765c04e6c1a
Cr-Commit-Position: refs/heads/master@{#301465}

[vignatti (out of this project), 2014-10-24 18:30:29]

tiago.vignatti@intel.com changed reviewers:
+ kpschoedel@chromium.org, spang@chromium.org

[vignatti (out of this project), 2014-10-24 18:30:46]

PTAL.

[spang, 2014-10-24 19:18:21]

Please rename KeyEventConverterEvdev to EventConverterEvdevImpl and add mouse
support there.

see crbug.com/412996

[vignatti (out of this project), 2014-10-24 20:17:34]

On 2014/10/24 19:18:21, spang wrote:
> Please rename KeyEventConverterEvdev to EventConverterEvdevImpl and add mouse
> support there.
> 
> see crbug.com/412996

good idea spang@. PTAL again.

[spang, 2014-10-24 20:44:04]

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:77: return;
please handle non-axis-aligned movement properly. Moving +4,+4 isn't the same as
moving +4,0 and then 0,+4.

Simultaneous changes to axes are delimited by EV_SYN, SYN_REPORT events.

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:79:
cursor_->MoveCursor(gfx::Vector2dF(x, y));
cursor can be NULL in which case all mouse events should be dropped.

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:97: flags =
ui::EF_MIDDLE_MOUSE_BUTTON;
Please handle modifiers properly; they are shared between devices. This way
doesn't support things like shift-click.

[vignatti (out of this project), 2014-10-27 17:57:08]

Thanks for the review spang. PTAnotherL.

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:77: return;
On 2014/10/24 20:44:04, spang wrote:
> please handle non-axis-aligned movement properly. Moving +4,+4 isn't the same
as
> moving +4,0 and then 0,+4.
> 
> Simultaneous changes to axes are delimited by EV_SYN, SYN_REPORT events.

Done.

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:79:
cursor_->MoveCursor(gfx::Vector2dF(x, y));
On 2014/10/24 20:44:03, spang wrote:
> cursor can be NULL in which case all mouse events should be dropped.

Done.

https://codereview.chromium.org/677113002/diff/40001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:97: flags =
ui::EF_MIDDLE_MOUSE_BUTTON;
On 2014/10/24 20:44:04, spang wrote:
> Please handle modifiers properly; they are shared between devices. This way
> doesn't support things like shift-click.

Done.

[spang, 2014-10-27 19:02:21]

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:63: if (input.type ==
EV_KEY)
Use switch/case

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:76: if (input.code == REL_X)
Use switch/case

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:88: if (input.code ==
BTN_LEFT)
Please rearrange this. Something like

if (input.code >= BTN_MOUSE && input.code < BTN_JOYSTICK)
  return DispatchMouseButton(input);

// Keyboard processing.

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:94: else {
if you use braces in any branch you must use them in all of them

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:115:
cursor_->MoveCursor(gfx::Vector2dF(x_offset_, y_offset_));
Please do not dispatch moves with (dx, dy) == (0, 0).

[vignatti (out of this project), 2014-10-27 20:07:30]

PTAL spang@

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:63: if (input.type ==
EV_KEY)
On 2014/10/27 19:02:21, spang wrote:
> Use switch/case

Done.

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:76: if (input.code == REL_X)
On 2014/10/27 19:02:21, spang wrote:
> Use switch/case

Done.

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:88: if (input.code ==
BTN_LEFT)
On 2014/10/27 19:02:21, spang wrote:
> Please rearrange this. Something like
> 
> if (input.code >= BTN_MOUSE && input.code < BTN_JOYSTICK)
>   return DispatchMouseButton(input);
> 
> // Keyboard processing.

Done.

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:94: else {
On 2014/10/27 19:02:21, spang wrote:
> if you use braces in any branch you must use them in all of them

Done.

https://codereview.chromium.org/677113002/diff/60001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:115:
cursor_->MoveCursor(gfx::Vector2dF(x_offset_, y_offset_));
On 2014/10/27 19:02:21, spang wrote:
> Please do not dispatch moves with (dx, dy) == (0, 0).

Done.

[spang, 2014-10-27 20:14:21]

lgtm with nits

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:106: return;
Move this to the top of the function.

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.h (right):

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.h:47: void FlushEvents(void);
Remove "void"

[vignatti (out of this project), 2014-10-27 20:22:53]

Thank you.

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.cc (right):

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.cc:106: return;
On 2014/10/27 20:14:21, spang wrote:
> Move this to the top of the function.

Done.

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_converter_evdev_impl.h (right):

https://codereview.chromium.org/677113002/diff/80001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_converter_evdev_impl.h:47: void FlushEvents(void);
On 2014/10/27 20:14:21, spang wrote:
> Remove "void"

Done.

[vignatti (out of this project), 2014-10-27 20:22:59]

The CQ bit was checked by tiago.vignatti@intel.com

[commit-bot: I haz the power, 2014-10-27 20:25:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/677113002/100001

[commit-bot: I haz the power, 2014-10-27 22:37:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-27 22:38:17]

Patchset 6 (id:??) landed as
https://crrev.com/e6e890a7ead1cca18d7f9fa9c75d9765c04e6c1a
Cr-Commit-Position: refs/heads/master@{#301465}