Change RepoSync to use -j4 option. Add tests to check for retries.

Change RepoSync to use -j4 option.  Add tests to check for retries.

BUG=chromium-os:13647
TEST=Ran cbuildbot locally to verify retries and increased speed.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4057aa2

[davidjames, 2011-04-01 20:20:27]

Only some small nits.

Otherwise, LGTM. This is really nice work. It's great that you took the time to
write tests for your little change because it makes the buildbot so much nicer
to work on.

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
File buildbot/cbuildbot_commands_unittest.py (right):

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:113: """Case where we exceed default
retry attempts"""
Please add a trailing period.

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:121: self.assertRaises(Exception, lambda
: commands._RepoSync(self._buildroot))
No need for the space between 'lambda' and ':'.

(Elsewhere in this file, I see that they use a space, but that's a typo I think
because the rest of chromite doesn't have a space after lambda.)

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:145: lambda :
commands._RepoSync(self._buildroot, retries=1))
Ditto.

[sosa, 2011-04-01 20:23:41]

LGTM w/ nit as well.  Also, please make sure to hit publish + mail comments when
sending out reviews so your reviewers get emailed out the original review :)

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands.py
File buildbot/cbuildbot_commands.py (right):

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands....
buildbot/cbuildbot_commands.py:56: cros_lib.OldRunCommand(['repo', 'sync', '-q',
'-j', '4'], cwd=buildroot)
can you change these short names to use long names?  Preferred to use long names
in code.

[rcui1, 2011-04-01 20:44:08]

Changes made (new cl uploaded to review site).  Thanks for the review!

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands.py
File buildbot/cbuildbot_commands.py (right):

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands....
buildbot/cbuildbot_commands.py:56: cros_lib.OldRunCommand(['repo', 'sync', '-q',
'-j', '4'], cwd=buildroot)
On 2011/04/01 20:23:41, sosa wrote:
> can you change these short names to use long names?  Preferred to use long
names
> in code.

Done.

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
File buildbot/cbuildbot_commands_unittest.py (right):

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:113: """Case where we exceed default
retry attempts"""
On 2011/04/01 20:20:27, davidjames wrote:
> Please add a trailing period.

Done.

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:121: self.assertRaises(Exception, lambda
: commands._RepoSync(self._buildroot))
On 2011/04/01 20:20:27, davidjames wrote:
> No need for the space between 'lambda' and ':'.
> 
> (Elsewhere in this file, I see that they use a space, but that's a typo I
think
> because the rest of chromite doesn't have a space after lambda.)

Done.

http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands_...
buildbot/cbuildbot_commands_unittest.py:145: lambda :
commands._RepoSync(self._buildroot, retries=1))
On 2011/04/01 20:20:27, davidjames wrote:
> Ditto.

Done.

[rcui1, 2011-04-01 21:10:12]

Checked in.