Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 6771036: Change RepoSync to use -j4 option. Add tests to check for retries. (Closed)

Created:
9 years, 11 months ago by rcui
Modified:
9 years, 11 months ago
CC:
chromium-os-reviews_chromium.org, sosa
Visibility:
Public.

Description

Change RepoSync to use -j4 option. Add tests to check for retries. BUG=chromium-os:13647 TEST=Ran cbuildbot locally to verify retries and increased speed. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4057aa2

Patch Set 1 #

Patch Set 2 : Split args #

Patch Set 3 : Add custom-retry-pass test and comments. Fix line length. #

Total comments: 8

Patch Set 4 : make reviewer requested changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M buildbot/cbuildbot_commands.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M buildbot/cbuildbot_commands_unittest.py View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidjames
Only some small nits. Otherwise, LGTM. This is really nice work. It's great that you ...
9 years, 11 months ago (2011-04-01 20:20:27 UTC) #1
rcui1
9 years, 11 months ago (2011-04-01 20:22:26 UTC) #2
sosa
LGTM w/ nit as well. Also, please make sure to hit publish + mail comments ...
9 years, 11 months ago (2011-04-01 20:23:41 UTC) #3
rcui1
Changes made (new cl uploaded to review site). Thanks for the review! http://codereview.chromium.org/6771036/diff/3001/buildbot/cbuildbot_commands.py File buildbot/cbuildbot_commands.py ...
9 years, 11 months ago (2011-04-01 20:44:08 UTC) #4
rcui1
9 years, 11 months ago (2011-04-01 21:10:12 UTC) #5
Checked in.

Powered by Google App Engine
This is Rietveld 408576698