Source/core/rendering/RenderTheme.h - Issue 677103002: Expand system font values during property parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderTheme.h

Issue 677103002: Expand system font values during property parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: OVERRIDE -> override, Allow CSSValueNone in systemFont() Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/StylePropertyShorthandCustom.cpp ('K') | « Source/core/css/resolver/StyleResolver.cpp ('k') | Source/core/rendering/RenderTheme.cpp » ('j') | Source/core/rendering/RenderTheme.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderTheme.h

diff --git a/Source/core/rendering/RenderTheme.h b/Source/core/rendering/RenderTheme.h

index 14fdf18b35162ac30d190a13ef38cd53f1e006de..fd6f3a777aa1f79bc003804ee63eedd4afc7992c 100644

--- a/Source/core/rendering/RenderTheme.h

+++ b/Source/core/rendering/RenderTheme.h

@@ -138,7 +138,8 @@ public:

virtual double caretBlinkInterval() const { return 0.5; }

// System fonts and colors for CSS.

- virtual void systemFont(CSSValueID, FontDescription&) const = 0;

+ virtual void systemFont(CSSValueID systemFontID, FontStyle&, FontWeight&, float& fontSize, AtomicString& fontFamily) const = 0;

+ void systemFont(CSSValueID systemFontID, FontDescription&);

virtual Color systemColor(CSSValueID) const;

virtual int minimumMenuListSize(RenderStyle*) const { return 0; }