Expand system font values during property parsing.

Source/core/css/StylePropertyShorthandCustom.cpp

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 114 matching lines @@
         return transitionShorthandForParsing();
     case CSSPropertyWebkitTransition:
         return webkitTransitionShorthandForParsing();
     default:
         return shorthandForProperty(propertyID);
     }
 }
 
 bool isExpandedShorthand(CSSPropertyID id)
 {
-    // The system fonts bypass the normal style resolution by using RenderTheme,
-    // thus we need to special case it here. FIXME: This is a violation of CSS 3 Fonts
-    // as we should still be able to change the longhands.
-    // DON'T ADD ANY SHORTHAND HERE UNLESS IT ISN'T ALWAYS EXPANDED AT PARSE TIME (which is wrong).
-    if (id == CSSPropertyFont)
-        return false;
-
     return shorthandForProperty(id).length();
 }
 
 bool isExpandedShorthandForAll(CSSPropertyID propertyId)

[Timothy Loh, 2014/10/27 05:45:46]

I think we can remove this function and just call isExpandedShorthand. Probably
you'll want to wait for https://codereview.chromium.org/339713008/ to land and
rebase over.

[andersr, 2014/10/27 10:58:29]

Done.

 {
     // FIXME: isExpandedShorthand says "font" is not an expanded shorthand,
     // but font is expanded to font-family, font-size, and so on.
     // StylePropertySerializer::asText should not generate css text like
     // "font: initial; font-family: initial;...". To avoid this, we need to
     // treat "font" as an expanded shorthand.
     // And while applying "all" property, we cannot apply "font" property
     // directly. This causes ASSERT crash, because StyleBuilder assume that
     // all given properties are not expanded shorthands.
     // "marker" has the same issue.
     if (propertyId == CSSPropertyMarker || propertyId == CSSPropertyFont)
         return true;
     return shorthandForProperty(propertyId).length();
 }
 
 unsigned indexOfShorthandForLonghand(CSSPropertyID shorthandID, const Vector<StylePropertyShorthand, 4>& shorthands)
 {
     for (unsigned i = 0; i < shorthands.size(); ++i) {
         if (shorthands.at(i).id() == shorthandID)
             return i;
     }
     ASSERT_NOT_REACHED();
     return 0;
 }
 
 } // namespace blink